Update backdrop explainer for JS#130
Open
AdaRoseCannon wants to merge 1 commit intoWebKit:mainfrom
Open
Conversation
Restructure the explainer around the JavaScript API on the <model> element (requestImmersive / exitImmersive), moving the previous declarative <link rel="spatial-backdrop"> design to "Alternative Considered". The imperative approach gives the page ownership of the activation UI, awareness of the current immersive state via immersivechange and a handle for controlling the backdrop after it is presented (entityTransform, environment map swaps, model animations). --------- Co-authored-by: Marcos Caceres <marcosc@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure the explainer around the JavaScript API on the element (requestImmersive / exitImmersive), moving the previous declarative design to "Alternative Considered".
The imperative approach gives the page ownership of the activation UI, awareness of the current immersive state via immersivechange and a handle for controlling the backdrop after it is presented (entityTransform, environment map swaps, model animations).