sql/plpgsql: report telemetry for the %TYPE / %ROWTYPE hint#169593
Open
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Open
sql/plpgsql: report telemetry for the %TYPE / %ROWTYPE hint#169593rafiss wants to merge 1 commit intocockroachdb:masterfrom
rafiss wants to merge 1 commit intocockroachdb:masterfrom
Conversation
The PL/pgSQL parser falls back to a heuristic error when type parsing fails and the type expression contains a `%`; the user is shown a hint suggesting they may have attempted to use `%TYPE` or `%ROWTYPE`. The old code attached an issue link to the error via `errors.WithIssueLink` but did not annotate it with `errors.WithTelemetry`, so this site produced no telemetry signal. Switch to `unimp.NewWithIssue(114676, ...)`, which both attaches the issue link and registers a telemetry counter, so future unimplemented-feature pulls bucket these errors under `unimplemented.cockroachdb#114676` instead of being invisible. Informs: cockroachdb#114676 Epic: CRDB-63280 Release note: None
rafiss
added
backport-25.4.x
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
bghal
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PL/pgSQL parser falls back to a heuristic error when type parsing fails and the type expression contains a
%; the user is shown a hint suggesting they may have attempted to use%TYPEor%ROWTYPE. The old code attached an issue link to the error viaerrors.WithIssueLinkbut did not annotate it witherrors.WithTelemetry, so this site produced no telemetry signal.Switch to
unimp.NewWithIssue(114676, ...), which both attaches the issue link and registers a telemetry counter, so future unimplemented-feature pulls bucket these errors underunimplemented.#114676instead of being invisible.Informs: #114676
Epic: CRDB-63280
Release note: None