Skip to content

Add Rust SDK (technical preview)#1164

Open
tclem wants to merge 84 commits intomainfrom
tclem/rust-sdk-release-prep
Open

Add Rust SDK (technical preview)#1164
tclem wants to merge 84 commits intomainfrom
tclem/rust-sdk-release-prep

Conversation

@tclem
Copy link
Copy Markdown
Member

@tclem tclem commented Apr 29, 2026

Adds a Rust SDK alongside the existing Node, Python, Go, and .NET SDKs in this repo. Same JSON-RPC client model, same protocol, same session lifecycle — just in Rust.

Important

Technical preview. This is published as github-copilot-sdk = "0.1" (pre-1.0) and the public API is subject to breaking changes as we iterate. Pin to an exact version, expect churn, and please file issues for friction or missing parity.

See rust/README.md for the full overview, examples, and the build/test commands. Generated types follow the same schema-driven flow used by the other SDKs (scripts/codegen/rust.ts).

CI for the new crate runs in .github/workflows/rust-sdk-tests.yml.

  Generated via Copilot (Claude Opus 4.7) on behalf of @tclem

tclem and others added 5 commits April 28, 2026 13:27
Adds the Copilot Rust SDK (`copilot-sdk` crate) under `rust/`,
alongside Rust codegen plumbed into `scripts/codegen/` and CI under
`.github/workflows/rust-sdk-tests.yml`. The crate ships a JSON-RPC
client, session lifecycle management, system message transforms,
permission policy helpers, the `define_tool` adapter, and per-event
`SessionHandler`/`SessionHooks` traits.

Includes:

- 14 ported E2E scenarios under `rust/tests/` driving the replay-proxy
  harness, plus a hand-curated set of unit tests.
- A rust-coding-skill (`.github/skills/rust-coding-skill/`) capturing
  conventions for error handling, async/concurrency, tracing, and the
  intentional trait exceptions in the SDK's public API.
- Release tooling: `rust-publish-release.yml`, `RELEASING.md`, and
  protocol-version generation wired into the existing automation.
- `PermissionResult` extended with `Deferred` and `Custom` variants
  for richer permission decisions.

Public API is held at 0.1.0-pre. Marked protocol-evolving public enums
`#[non_exhaustive]` so additive variants stay non-breaking.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
Co-authored-by: David Dossett <25163139+daviddossett@users.noreply.github.com>
Co-authored-by: Devraj Mehta <devm33@github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Evan Boyle <EvanBoyle@users.noreply.github.com>
Co-authored-by: Jeremy Moseley <jemoseley@microsoft.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
- **Broadcast subscriptions for lifecycle and session events.**
  `Client::subscribe_lifecycle()` and `Session::subscribe()` return
  `tokio::sync::broadcast::Receiver`; dropping the receiver
  unsubscribes. Replaces the prior callback-based `Client::on`,
  `Client::on_event_type`, `Session::on`, and `Unsubscribe` API.
  Spawned consumer tasks isolate panics naturally.
- **`PermissionResult` gains `Deferred` and `Custom` variants.**
  `Deferred` lets handlers resolve a request asynchronously via
  `session.permissions.handlePendingPermissionRequest` (notification
  path only — falls back to `Approved` on the direct RPC path).
  `Custom(Value)` lets handlers send arbitrary response payloads
  beyond the standard `approve-once` / `reject` shapes.
- **`#[non_exhaustive]` on protocol-evolving public enums**
  (`PermissionResult`, `SessionLifecycleEventType`,
  `GitHubReferenceType`, others) so additive variants stay
  non-breaking.
- **`ToolHandlerRouter` overrides per-event `SessionHandler` methods**
  so consumers can call `router.on_external_tool(...)` directly
  without unwrapping `HandlerResponse`.
- **`define_tool` accepts bare `async fn` items** in addition to
  closures, matching `tower::service_fn` /
  `hyper::service::service_fn` conventions. Documented in rustdoc.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ypes

Generated code emitted `pub session_id: String` for every schema field named
`sessionId` and likewise for `requestId`, leaving consumers with mixed types:
`Session::id()` returned `SessionId` but `session.events_subscribe()` events
exposed `session_id: String`. Same papercut for request IDs in permission and
elicitation event payloads.

The newtypes are `#[serde(transparent)]` so the wire format is unchanged. This
adds a property-name override map to `scripts/codegen/rust.ts` that maps
`sessionId`, `remoteSessionId`, and `requestId` to the hand-authored types in
`crate::types`, and emits the matching `use` statement in both generated
modules. `mc_session_id` (MCP protocol metadata, not a Copilot session) stays
as `String`.

After regeneration: 27 fields converted to `SessionId` (including the handoff
event's `remoteSessionId`) and 25 to `RequestId`. The existing `PartialEq<str>`
/ `PartialEq<String>` impls on both newtypes mean test code like

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
define_tool's Fn(P) -> Fut bound gave closures only the deserialized
arguments, leaving session_id, tool_call_id, and tool_name unreachable.
That blocked the helper for any tool that needs to scope DB lookups to
a session, emit per-tool-call telemetry, or stream UI updates back to
the originating session — patterns that hit dozens of sites across
realistic tool suites.

Change the closure bound to Fn(ToolInvocation, P) -> Fut. The arguments
are moved out via mem::take before deserialization, so there is no
clone cost on the hot path. Closures that don't need the metadata
write |_inv, params|.

Also add ToolInvocation::params<P>() so long-form impl ToolHandler
blocks can deserialize without naming serde_json directly:

    async fn call(&self, inv: ToolInvocation) -> Result<ToolResult, Error> {
        let params: MyParams = inv.params()?;
        // …use inv.session_id alongside params…
    }

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Node, Python, and .NET all expose ping with an optional message.
Go requires it only because Go has no Option type — Rust has one,
so the API should match the languages with the same expressive power
rather than the one without.

Change ping(&self, message: &str) to ping(&self, message: Option<&str>).
When None, the message field is omitted from the request payload
rather than sent as an empty string.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 29, 2026 14:09
@tclem tclem requested a review from a team as a code owner April 29, 2026 14:09
@tclem tclem marked this pull request as draft April 29, 2026 14:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Rust SDK crate (copilot-sdk, library name copilot) to the monorepo, mirroring the existing SDKs’ JSON-RPC client/session model, and wires it into repo workflows and scenario coverage.

Changes:

  • Introduces the Rust SDK crate with protocol types, JSON-RPC transport, session/handler abstractions, examples, and tests.
  • Extends scenario samples and verification scripts to build/run Rust implementations alongside TS/Python/Go/C#.
  • Updates repo automation: codegen, just tasks, scenario-build CI, Rust SDK CI, and release/publish workflows.
Show a summary per file
File Description
test/scenarios/verify.sh Shows Rust status in the aggregated scenario runner UI.
test/scenarios/transport/tcp/verify.sh Builds/runs the Rust TCP transport scenario.
test/scenarios/transport/tcp/rust/Cargo.toml Rust TCP scenario crate manifest.
test/scenarios/transport/tcp/rust/src/main.rs Rust TCP sample using external host:port CLI server.
test/scenarios/transport/stdio/verify.sh Builds/runs the Rust stdio transport scenario.
test/scenarios/transport/stdio/rust/Cargo.toml Rust stdio scenario crate manifest.
test/scenarios/transport/stdio/rust/src/main.rs Rust stdio sample spawning the CLI child process.
test/scenarios/transport/stdio/README.md Documents Rust sample location/package name.
test/scenarios/tools/tool-overrides/verify.sh Builds/runs Rust tool override scenario.
test/scenarios/tools/tool-overrides/rust/Cargo.toml Rust tool-overrides scenario crate manifest (+derive).
test/scenarios/tools/tool-overrides/rust/src/main.rs Rust sample overriding built-in tool behavior.
test/scenarios/tools/tool-filtering/verify.sh Builds/runs Rust tool filtering scenario.
test/scenarios/tools/tool-filtering/rust/Cargo.toml Rust tool-filtering scenario crate manifest.
test/scenarios/tools/tool-filtering/rust/src/main.rs Rust sample limiting available tools.
test/scenarios/tools/skills/verify.sh Builds/runs Rust skills scenario.
test/scenarios/tools/skills/rust/Cargo.toml Rust skills scenario crate manifest.
test/scenarios/tools/skills/rust/src/main.rs Rust sample configuring skill directories + hooks.
test/scenarios/tools/no-tools/verify.sh Builds/runs Rust no-tools scenario.
test/scenarios/tools/no-tools/rust/Cargo.toml Rust no-tools scenario crate manifest.
test/scenarios/tools/no-tools/rust/src/main.rs Rust sample disabling tools + replacing system prompt.
test/scenarios/tools/mcp-servers/verify.sh Builds/runs Rust MCP servers scenario.
test/scenarios/tools/mcp-servers/rust/Cargo.toml Rust mcp-servers scenario crate manifest.
test/scenarios/tools/mcp-servers/rust/src/main.rs Rust sample passing MCP servers config to CLI.
test/scenarios/tools/custom-agents/verify.sh Builds/runs Rust custom agents scenario.
test/scenarios/tools/custom-agents/rust/Cargo.toml Rust custom-agents scenario crate manifest (+derive).
test/scenarios/tools/custom-agents/rust/src/main.rs Rust sample defining custom agents + custom tool.
test/scenarios/sessions/streaming/verify.sh Builds/runs Rust streaming scenario.
test/scenarios/sessions/streaming/rust/Cargo.toml Rust streaming scenario crate manifest.
test/scenarios/sessions/streaming/rust/src/main.rs Rust sample counting streaming delta events.
test/scenarios/sessions/session-resume/verify.sh Builds/runs Rust session resume scenario.
test/scenarios/sessions/session-resume/rust/Cargo.toml Rust session-resume scenario crate manifest.
test/scenarios/sessions/session-resume/rust/src/main.rs Rust sample creating + resuming session by ID.
test/scenarios/sessions/infinite-sessions/verify.sh Builds/runs Rust infinite sessions scenario.
test/scenarios/sessions/infinite-sessions/rust/Cargo.toml Rust infinite-sessions scenario crate manifest.
test/scenarios/sessions/infinite-sessions/rust/src/main.rs Rust sample exercising infinite session thresholds.
test/scenarios/sessions/concurrent-sessions/verify.sh Builds/runs Rust concurrent sessions scenario.
test/scenarios/sessions/concurrent-sessions/rust/Cargo.toml Rust concurrent-sessions scenario crate manifest.
test/scenarios/sessions/concurrent-sessions/rust/src/main.rs Rust sample running two sessions concurrently.
test/scenarios/prompts/system-message/verify.sh Builds/runs Rust system-message scenario.
test/scenarios/prompts/system-message/rust/Cargo.toml Rust system-message scenario crate manifest.
test/scenarios/prompts/system-message/rust/src/main.rs Rust sample replacing system message.
test/scenarios/prompts/reasoning-effort/verify.sh Builds/runs Rust reasoning-effort scenario.
test/scenarios/prompts/reasoning-effort/rust/Cargo.toml Rust reasoning-effort scenario crate manifest.
test/scenarios/prompts/reasoning-effort/rust/src/main.rs Rust sample setting reasoning_effort.
test/scenarios/modes/default/verify.sh Builds/runs Rust default mode scenario.
test/scenarios/modes/default/rust/Cargo.toml Rust default-mode scenario crate manifest.
test/scenarios/modes/default/rust/src/main.rs Rust sample using default tool-enabled mode.
test/scenarios/callbacks/user-input/verify.sh Builds/runs Rust user-input callback scenario.
test/scenarios/callbacks/user-input/rust/Cargo.toml Rust user-input scenario crate manifest.
test/scenarios/callbacks/user-input/rust/src/main.rs Rust sample handling ask_user prompts.
test/scenarios/callbacks/permissions/verify.sh Builds/runs Rust permission callback scenario.
test/scenarios/callbacks/permissions/rust/Cargo.toml Rust permissions scenario crate manifest.
test/scenarios/callbacks/permissions/rust/src/main.rs Rust sample logging/approving permissions.
test/scenarios/callbacks/hooks/verify.sh Builds/runs Rust hooks callback scenario.
test/scenarios/callbacks/hooks/rust/Cargo.toml Rust hooks scenario crate manifest.
test/scenarios/callbacks/hooks/rust/src/main.rs Rust sample implementing SessionHooks logging.
test/scenarios/RUST_COVERAGE.md Documents Rust scenario parity coverage/gaps.
scripts/codegen/package.json Adds Rust generation to codegen scripts.
nodejs/scripts/update-protocol-version.ts Generates Rust SDK protocol version constant.
justfile Adds Rust format/lint/test/codegen tasks.
.gitignore Ignores Rust scenario build artifacts/lockfiles.
.github/workflows/scenario-builds.yml Adds CI job building all Rust scenario crates.
.github/workflows/rust-sdk-tests.yml Adds Rust SDK CI (fmt/clippy/doc/test/semver-checks).
.github/workflows/rust-release-pr.yml Adds release-plz workflow to open Rust release PRs.
.github/workflows/rust-publish-release.yml Adds release-plz workflow to publish Rust crate.
.github/workflows/codegen-check.yml Ensures Rust codegen + protocol version regen in CI.
.github/skills/rust-coding-skill/SKILL.md Adds repo-specific Rust engineering guidance.
.github/skills/rust-coding-skill/examples.md Adds Rust SDK examples/patterns for contributors.
.github/copilot-instructions.md Updates repo guidance to include Rust SDK + Rust skill.
rust/Cargo.toml Defines the new copilot-sdk crate (features, deps, MSRV).
rust/Cargo.lock Locks Rust dependencies for deterministic builds.
rust/README.md Documents Rust SDK usage, architecture, and API surface.
rust/CHANGELOG.md Establishes initial changelog and release-plz plan.
rust/RELEASING.md Documents release/publish operations for maintainers.
rust/LICENSE Rust crate license file.
rust/rust-toolchain.toml Pins Rust toolchain version/components for the crate.
rust/release-plz.toml Configures release-plz behavior for the Rust crate.
rust/clippy.toml Configures Rust clippy rules (e.g., disallowed macros).
rust/.rustfmt.toml Stable rustfmt config (edition 2024).
rust/.rustfmt.nightly.toml Nightly rustfmt config enabling unstable formatting opts.
rust/.gitignore Ignores Rust target dir and backup lock files.
rust/build.rs Build-time CLI bundling/extraction codegen support.
rust/src/sdk_protocol_version.rs Generated SDK protocol version constant for Rust.
rust/src/generated/mod.rs Rust generated-type module root + re-exports.
rust/src/jsonrpc.rs Content-Length framed JSON-RPC transport implementation.
rust/src/router.rs Per-session routing of notifications/requests.
rust/src/handler.rs Session handler traits/events + default handlers.
rust/src/permission.rs Permission policy wrappers over SessionHandler.
rust/src/transforms.rs System message transform extension point + dispatcher.
rust/src/session.rs Session lifecycle/event loop plumbing (core runtime).
rust/tests/jsonrpc_test.rs Tests for JSON-RPC framing/routing (feature-gated).
rust/tests/protocol_version_test.rs Tests protocol version negotiation behavior.
rust/tests/integration_test.rs Ignored integration tests against real CLI.
rust/examples/chat.rs Interactive streaming chat example.
rust/examples/hooks.rs Hooks example for logging/auditing.
rust/examples/tool_server.rs Tool server example (feature-gated on derive).
rust/examples/lifecycle_observer.rs Observer example for lifecycle/session event streams.

Copilot's findings

  • Files reviewed: 102/107 changed files
  • Comments generated: 5

Comment thread rust/src/session.rs Outdated
Comment thread rust/build.rs
Comment thread rust/README.md Outdated
Comment thread test/scenarios/sessions/streaming/verify.sh
Comment thread .github/workflows/scenario-builds.yml
tclem and others added 5 commits April 29, 2026 07:24
cargo doc was running with --features test-support, which left the
derive feature off and made intra-doc links to define_tool and
schema_for resolve to nothing — failing under the crate's
deny(rustdoc::broken_intra_doc_links).

docs.rs already uses all-features (see Cargo.toml's
[package.metadata.docs.rs]); align CI with that so the docs job
matches what users will see on docs.rs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  emitted from the loop correlate to a session in traces. Matches
  the pattern documented in the rust-coding-skill.

- README.md / embeddedcli.rs: correct the embedded-CLI documentation
  to match what build.rs and embeddedcli.rs actually do — archives
  come from the github/copilot-cli GitHub Releases, integrity is
  SHA-256 against SHA256SUMS.txt, and the runtime cache path is
  ~/.cache/copilot-sdk-{version}/copilot.

- test/scenarios/sessions/streaming/verify.sh: drop a duplicate
  '# Go: build' comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Picks up the new model.call_failure session event (with its
ModelCallFailureData payload and ModelCallFailureSource enum) and
the new optional 'tip' field on session_info.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Removes path triggers and the regenerate step for other languages'
protocol-version files. Those drift checks are a pre-existing gap on
main and out of scope for the Rust SDK port.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tclem and others added 2 commits April 29, 2026 07:41
The 23-line setup checklist duplicated content already in
rust/RELEASING.md. One-line pointer is enough.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Two scenarios still used the old `Fn(P) -> Fut` shape and broke when
the SDK switched to `Fn(ToolInvocation, P) -> Fut`. They don't use
the invocation field, so just bind it as `_inv`.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by SDK Consistency Review Agent for issue #1164 · ● 2.5M

Comment thread rust/src/session.rs Outdated
Cross-SDK consistency: every other SDK (Node, Python, Go, .NET) uses
`send`/`Send`/`SendAsync` plus `MessageOptions` as the public
parameter type. Rust was the outlier with `send_message` and
`SendOptions`, and the asymmetry with the existing `send_and_wait`
method made it read awkwardly.

- Rename `Session::send_message` -> `Session::send` (and the private
  helper `send_message_inner` -> `send_inner`).
- Rename the public `SendOptions` type -> `MessageOptions`.
- Delete the previous wire-level `MessageOptions` struct: it had no
  internal callers (the wire payload is hand-rolled in send_inner) and
  freeing the name was the cleanest path to parity.

Pre-1.0 type rename, no protocol or behavior change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread .github/skills/rust-coding-skill/SKILL.md
Comment thread .github/skills/rust-coding-skill/SKILL.md
Comment thread .github/copilot-instructions.md Outdated
Comment thread rust/src/session.rs
Comment thread rust/src/lib.rs
Comment thread rust/src/types.rs Outdated
Comment thread rust/src/session.rs Outdated
Comment thread rust/src/types.rs
Comment thread rust/Cargo.toml Outdated
Comment thread rust/Cargo.toml Outdated
@stephentoub
Copy link
Copy Markdown
Collaborator

Thanks for getting this up.

It'd be helpful to run an agent over the other SDKs and this new one to look for any inconsistencies / gaps / divergences, so that we can then evaluate each and decide whether it's acceptable or should be addressed. The more consistent we can be across the SDKs, the easier it'll be to maintain them moving forward, the more information / docs about one will translate to consumption of the others, the better we'll be able to evolve with reduced concerns for how something we want to add may not fit well in a particular SDK, etc.

@github-actions

This comment has been minimized.

Previously Session::subscribe and Client::subscribe_lifecycle returned
raw tokio::sync::broadcast::Receiver<T> values. A survey of mature Rust
crates (tonic, lapin, rdkafka, redis-rs, tokio-tungstenite, iroh-gossip,
tokio-stream's BroadcastStream itself) found that none of them expose a
raw broadcast::Receiver in their public API; the dominant pattern is a
named newtype implementing futures::Stream, with overflow surfaced
explicitly in the item type.

Introduce a copilot::subscription module with:

  - EventSubscription / LifecycleSubscription newtypes
  - Inherent recv() returning Result<T, RecvError> for existing
    while-let loop ergonomics
  - Stream impl yielding Result<T, Lagged> so callers can use
    tokio_stream::StreamExt or futures::StreamExt combinators
  - Lagged / RecvError types owned by the SDK so consumers no longer
    import tokio's broadcast error types

Net effect: the channel choice is now an internal implementation detail.
We can swap broadcast for async-broadcast / flume / a custom backpressure
policy, or convert lag into an Event::Lagged variant, without a breaking
change to the public surface.

Existing while-let loops in tests and examples continue to compile and
behave identically: close and lag both exit the loop, matching
tokio::sync::broadcast::Receiver.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@tclem tclem marked this pull request as ready for review April 29, 2026 16:19
@tclem tclem marked this pull request as draft April 29, 2026 16:20
Local cargo +nightly fmt --check passed without `--config-path
.rustfmt.nightly.toml`, but CI runs with the explicit config and
flagged two diffs: import group flattening and test-mod import order.
Applied with the same flags CI uses.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread rust/src/generated/session_events.rs
/// Unique event identifier (UUID v4).
pub id: String,
/// ISO 8601 timestamp when the event was created.
pub timestamp: String,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here: is there a datetime type that could be used rather than string? The schema includes a format specifier to indicate when that'd be appropriate.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as uuid, we could bring in a dependency... if we think it's worth it. std::time is intentionally minimal and free of calendar complexity, timezones, etc.

Is this important for the sdk?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these timestamp ones are more worthwhile, so I'd go for this one if it's easy enough. Folks are more likely to actually use this data, compare time stamps, etc.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need chrono for that.. which is a pretty big dependency to bring in for this capability... Let me audit in a bit more detail how many timestamps we're dealing with here and keep in might usage (like comparison) and see if I can propose something a bit more lightweight.

Ideally, we push a few 3rd party deps as possible on consumers.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://crates.io/crates/time-format is the other options... though I kinda wonder if serde already has a dependency on one of these...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's going to be a problem, we can skip. C#, Go, and Python do all special-case this, though (TypeScript doesn't).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. If you feel strongly that we should make this a real type and not a string. My recommendation is time-format - zero dependencies, tiny (575 SLoC). chrono is 20K SLoC with a big list of dependencies.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about it. Up to you whether you think it's worth it.

tclem and others added 3 commits May 1, 2026 17:57
stephentoub and tclem agreed the Skills section is unnecessary
prompt-pollution. Skills are auto-discovered by Copilot CLI without
needing to be enumerated in the instructions, and the one-line
description of each skill duplicates what the SKILL.md frontmatter
already says.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codegen previously emitted a single bare `/// Stability: experimental.`
line on each experimental wire method. stephentoub flagged this as
weak signal -- there's no way for a consumer to tell from the rustdoc
that they're using something that may change.

Switch the rustdoc emit to a `<div class="warning">...</div>` block,
which renders on docs.rs as a yellow-bordered callout (the standard
rustdoc admonition convention). Matches the visibility Python's
generated docs already get via Sphinx's `.. warning::` directive.

This is documentation-quality only; no compile-time opt-in. Stable
Rust has no first-class `#[experimental]` attribute (`#[unstable]`
is rustc-internal, std-only). If we ever want compile-time friction
the ecosystem patterns are a Cargo feature gate (e.g. `tokio_unstable`-
style `features = ["experimental"]`) or an `unstable` module path;
both are larger codegen changes affecting every experimental RPC
across all SDK surfaces. Punted for 0.1.0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The "anti-pattern" framing in examples.md was misleading -- it implied
the RefCell example might compile but produce bugs at runtime. In
reality, SessionHandler's `Send + Sync + 'static` trait bound rejects
any handler whose state contains a non-Sync type (RefCell, Cell, Rc),
so the example fails at the impl site, not at use.

Reframe as "Won't compile", show the actual trait-bound error inline,
and add a one-paragraph note explaining the compiler-level enforcement
so a reader doesn't have to mentally trace
`spawn -> Send + Sync -> RefCell !Sync`. Addresses stephentoub's
review feedback that the prior framing read as "we've buried some
unsafe usage."

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

tclem and others added 2 commits May 1, 2026 18:21
Replaces the per-session `Arc<Notify>` shutdown signal with
`tokio_util::sync::CancellationToken`, the canonical primitive for
SDK-internal task coordination in async Rust. Same cooperative-shutdown
semantics, materially better fit for the use case:

- `tonic` uses `CancellationToken` for the equivalent task coordination
  case (request cancel propagated into spawned server handlers).
- Parent/child token tree gives us a clean way to expose a public
  `Session::cancellation_token()` accessor that returns a child token —
  consumers can `select!` on `child.cancelled()` to bind their own work
  to the session lifetime, but cancelling the child does NOT shut down
  the session itself (child cancel is isolated).
- `Drop` impl just calls `cancel()`, no buffering quirks (Notify's
  `notify_one` was already documented as buffer-on-no-listeners; token
  cancellation is sticky, which is the simpler mental model).

Plumbing:

- `tokio-util = { version = "0.7", default-features = false }` added as
  a runtime dep. No new transitive deps the SDK didn't already pull
  through tokio.
- `Session.shutdown` field type changes from `Arc<Notify>` to
  `CancellationToken` (which is itself internally `Arc`-backed and
  `Clone`).
- `stop_event_loop()` calls `cancel()` instead of `notify_one()`.
- `Drop` impl calls `cancel()` instead of `notify_one()`.
- Event-loop `select!` arm becomes `_ = shutdown.cancelled() => break`.
- New public `Session::cancellation_token()` returning a `child_token()`
  — power-user API for binding external tasks to session lifetime.

Tests:

- `cancellation_token_fires_on_session_drop`: dropping the session
  fires the child token within 2s.
- `cancellation_token_child_cancel_does_not_kill_session`: cancelling
  a child does not propagate up to the parent.

Closes the cancellation idiom gap stephentoub flagged on the SKILL doc.
The framing "drop the future or call abort()" was too absolute — drop-
to-cancel is the right primitive for caller-owned futures, but for
SDK-internal task coordination CancellationToken is the canonical
answer (citations: tokio-util docs, tonic cancellation example,
withoutboats "Asynchronous clean-up", `tokio-graceful-shutdown` crate).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
stephentoub flagged that the "Idioms that don't port from Go or Node"
section was lopsided (no C# / Python mention) and that the cancellation
guidance was too absolute (it dismissed `ctx.Done()` analogs without
mentioning tokio_util's CancellationToken).

Both true. Replaces the section with a thorough rewrite covering all
four idioms with citations and decision matrices:

1. Event subscription: keep "channels not callbacks" baseline; add the
   full primitive matrix (mpsc / oneshot / broadcast / watch); explain
   that the public API should expose `impl Stream<Item = T>` (the
   canonical IObservable<T> analog), citing tonic / reqwest / sqlx as
   precedent.
2. Cancellation: rewrite. "Drop = cancel" is the primitive for
   caller-owned futures. `tokio_util::sync::CancellationToken` is the
   canonical answer for SDK-internal task coordination — citations to
   tonic's cancellation example, tokio-util docs, withoutboats blog
   post, and Cybernetist's task cancellation patterns survey. Notes
   the SDK's own `Session.shutdown: CancellationToken` field and the
   `Session::cancellation_token()` accessor.
3. Optional fields: confirm Option<T> + Default baseline; add
   non_exhaustive + builder pairing (AWS SDK convention); note when
   typestate / Result-from-build is the right answer.
4. serde JSON: confirm rename_all + per-field rename baseline; add
   skip_serializing_if = "Option::is_none" for output omission and
   #[serde(default)] for input tolerance (LSP/JSON-RPC convention).

Section title is also de-language-coupled: "Idioms that don't port
from other languages" instead of "...from Go or Node". Lists Node /
Python / C# / Go equivalents inline where pattern divergence is
notable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by SDK Consistency Review Agent for issue #1164 · ● 3.4M

Comment thread rust/src/types.rs
/// System-message transform. See [`SessionConfig::transform`].
#[serde(skip)]
pub transform: Option<Arc<dyn SystemMessageTransform>>,
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-SDK consistency gap: continue_pending_work missing from ResumeSessionConfig

All other SDKs expose a continuePendingWork flag on their resume config that instructs the CLI to preserve in-flight tool calls and permission requests across reconnections rather than treating them as interrupted. This field is absent from the Rust ResumeSessionConfig.

Other SDK equivalents:

  • Node.js: ResumeSessionConfig.continuePendingWork?: boolean (nodejs/src/types.ts:1435)
  • Go: ResumeSessionConfig.ContinuePendingWork bool (go/types.go:815)
  • Python: continue_pending_work: bool | None in ResumeSessionConfig (python/copilot/client.py:1516)
  • .NET: bool? ContinuePendingWork on ResumeSessionConfig (dotnet/src/Types.cs:2189)

The generated SessionResumeData event does have a continue_pending_work field (to reflect the server's decision at runtime), but the request side — the config the caller sends to opt in — is missing here.

Suggested addition (right before disable_resume):

/// When `true`, the runtime continues any tool calls or permission requests
/// that were still pending when the session was last disconnected.
/// When `false` (the default), pending work is treated as interrupted on resume.
///
/// For permission requests, the runtime re-emits `permission.requested`; for
/// external tool calls, supply the result via the corresponding low-level RPC.
#[serde(skip_serializing_if = "Option::is_none")]
pub continue_pending_work: Option<bool>,

A matching with_continue_pending_work(bool) builder method near with_disable_resume would complete the parity. This gap is not called out in the README's "Differences From Other SDKs" section, so it appears unintentional.

tclem and others added 2 commits May 1, 2026 20:06
The wire-protocol schema added top-level `agentId?: string` to every
session event envelope in commit f8cf846 ("Derive session event
envelopes from schema") for sub-agent attribution. Every other SDK
carries it; Rust silently drops it at the deserialization boundary.

Concretely: the schema describes `agentId` as "Sub-agent instance
identifier. Absent for events from the root/main agent and session-
level events." Without the field, Rust consumers can't distinguish
events emitted by a sub-agent from events emitted by the root agent.

Adds:
- `pub agent_id: Option<String>` on `types::SessionEvent` (hand-
  authored consumer-facing).
- `pub agent_id: Option<String>` on
  `generated::session_events::TypedSessionEvent` via codegen update
  in `scripts/codegen/rust.ts`.
- `#[serde(rename = "agentId", skip_serializing_if = "Option::is_none")]`
  via the existing container `rename_all = "camelCase"` (covered) plus
  skip-on-None for clean wire output.

Round-trip tests cover both struct shapes — sub-agent event with the
field set, root-agent event without — to lock the parity in place
against future schema changes or codegen regressions.

Caught by a fresh parity audit against Node/Python/Go/.NET as part of
the post-main-merge gap review.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accidentally committed by the parity audit run; not intended as
repo artifacts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by SDK Consistency Review Agent for issue #1164 · ● 2.2M

Comment thread rust/src/types.rs
…n pattern

Two changes prompted by review:

1. SKILL.md was too prose-heavy for an agent to scan. The "Idioms that
   don't port from other languages" section had grown to ~110 lines of
   essay-shaped advice with key rules buried in narrative. Replaced
   with three tight rule sections (Concurrency primitives, Optional
   fields and serde, plus a one-paragraph cross-language porting note
   that points back to the rule sections). Net: 345 -> 255 lines, no
   rule lost.

2. The trait-vs-callback-fields rule was implicit in the SessionHandler
   description but not explicit. Codified in "Traits and conversions"
   as a primary directive: prefer one trait with one default-impl
   method per event over per-event Box<dyn Fn> fields. Cited the three
   precedent traits in async Rust:

   - tower_lsp::LanguageServer (63 methods, default impls; LSP wire
     protocol)
   - rmcp::ServerHandler (26 methods, all default; MCP wire protocol)
   - notify::EventHandler (single on_event(enum) for uniform-shape
     events)

   Confirmed via research that no major async Rust crate ships
   per-event Box<dyn Fn> callback fields as its primary API; the
   pattern fights Send + Sync + 'static, fragments consumer state
   across closures, and skips exhaustiveness. The SDK's SessionHandler
   already uses the recommended shape (per-method with defaults plus a
   default on_event dispatcher); the doc just hadn't named the pattern.

Section ordering tightened: Traits/conversions now leads into
Extension points, then Concurrency primitives (channels matrix +
cancellation), then Optional fields/serde. Reads top-to-bottom for
an agent picking up a fresh task.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by SDK Consistency Review Agent for issue #1164 · ● 1.9M

Comment thread rust/src/types.rs
/// Force-fail resume if the session does not exist on disk, instead of
/// silently starting a new session.
#[serde(skip_serializing_if = "Option::is_none")]
pub disable_resume: Option<bool>,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-SDK consistency gap: continue_pending_work missing from ResumeSessionConfig

All other SDKs expose a continuePendingWork / continue_pending_work / ContinuePendingWork field on their resume config, but the Rust ResumeSessionConfig doesn't include it:

SDK Field
Node.js continuePendingWork?: boolean
Python continue_pending_work: bool
Go ContinuePendingWork bool
.NET bool? ContinuePendingWork
Rust ❌ missing

This field is important for the "pending work resume" pattern — when a session is abandoned mid-tool-execution (e.g. via force_stop), setting continue_pending_work: true on resume instructs the CLI to replay and complete those pending tool/permission requests.

Suggested addition (after disable_resume):

/// When `true`, instructs the runtime to continue any pending tool calls
/// or permission requests that were outstanding when the session was
/// last disconnected. Use in combination with [`Client::force_stop`] to
/// hand off a live session to a new client without losing in-flight work.
/// See [`SessionConfig`] for the equivalent field on initial session creation.
#[serde(skip_serializing_if = "Option::is_none")]
pub continue_pending_work: Option<bool>,

And a corresponding builder method in impl ResumeSessionConfig:

pub fn with_continue_pending_work(mut self, value: bool) -> Self {
    self.continue_pending_work = Some(value);
    self
}

Don't forget to include it in ResumeSessionConfig::new (as None) and in the Debug impl.

Cross-SDK parity gap caught by the SDK consistency reviewer. All
four other SDKs (Node, Python, Go, .NET) expose this field; Rust
omitted it.

The field opts the runtime into continuing any tool calls or
permission requests that were pending when the previous connection
was dropped — it's the key enabler of the pending-work-handoff
pattern used together with `Client::force_stop` to migrate a session
from one process to another without losing in-flight work.

Plumbing:

- `pub continue_pending_work: Option<bool>` on `ResumeSessionConfig`
  with `#[serde(skip_serializing_if = "Option::is_none")]`. Container
  `rename_all = "camelCase"` covers the wire-name `continuePendingWork`.
  No manual payload-construction code is needed; resume_session
  serializes config -> wire via `serde_json::to_value(&config)`.
- `with_continue_pending_work(bool)` builder.
- Default impl: `None`.
- Debug impl: includes the field.

Tests:

- `resume_session_config_builder_composes` extended to cover the
  new field.
- `resume_session_config_serializes_continue_pending_work_to_camel_case`
  asserts the wire shape (`continuePendingWork: true`) and that
  unset values are omitted (skip_serializing_if).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by SDK Consistency Review Agent for issue #1164 · ● 2.8M

Comment thread rust/README.md
`AutoModeSwitchResponse::{Yes, YesAlways, No}`. Default impl declines.
Cross-SDK parity is post-release follow-up — Node / Python / Go / .NET
consumers currently observe the request as a raw event and must drive
the wire response themselves.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Rust-only API" section documents on_auto_mode_switch as a Rust-only typed handler with a note that "Cross-SDK parity is post-release follow-up." The on_exit_plan_mode handler on SessionHandler is in the same situation — it's a typed Rust-only callback for exit_plan_mode.requested (other SDKs expose this only as a raw SessionEvent with no typed dispatch path), but it isn't mentioned here.

Worth adding a parallel bullet for on_exit_plan_mode so consumers have the same explicit heads-up that they would for on_auto_mode_switch:

- **`SessionHandler::on_exit_plan_mode`** — typed handler for the CLI's
  plan-mode exit prompt (`exit_plan_mode.requested`). Returns
  `ExitPlanModeResult` (default: approved with no action). Cross-SDK parity
  is post-release follow-up — Node / Python / Go / .NET consumers currently
  observe the request as a raw event and must drive the wire response
  themselves.

Minor documentation gap only — no code change needed.

Closes three cross-SDK parity gaps surfaced by the post-merge audit
against upstream commits 662f270, d3abfa2, and 180ca47.

ClientOptions::copilot_home: Option<PathBuf>
- Override the CLI's data directory. Exported as COPILOT_HOME to the
  spawned CLI process. Mirrors Node's copilotHome / Python's
  copilot_home.

ClientOptions::tcp_connection_token: Option<String>
- Optional auth token for TCP transport. Sent in the new `connect`
  JSON-RPC handshake (with backward-compat fall-back to `ping` for
  legacy CLI servers) and exported as COPILOT_CONNECTION_TOKEN to
  spawned CLI processes. When the SDK spawns its own CLI in TCP mode
  and this is unset, a UUID is generated so the loopback listener is
  safe by default. Combining with Transport::Stdio returns
  Error::InvalidConfig from Client::start. Mirrors Node's
  tcpConnectionToken / Python's tcp_connection_token / .NET's
  TcpConnectionToken.
- New `connect` handshake: verify_protocol_version now calls `connect`
  first, falling back to `ping` on -32601 MethodNotFound. The handshake
  carries the effective connection token. Matches Node's
  internalRpc.connect({ token }) sequence in client.ts.
- Adds `uuid` build-dep (1.x with v4 feature) for the auto-generated
  loopback token. Cryptographically-secure source via getrandom (already
  in the transitive dep tree).

SessionConfig::instruction_directories + ResumeSessionConfig::
instruction_directories: Option<Vec<PathBuf>>
- Additional directories the CLI searches for custom instruction files,
  distinct from skill_directories. Pure passthrough on the wire.
  Mirrors Node/Python instructionDirectories.

Error::InvalidConfig(String)
- New #[non_exhaustive] variant for client-construction errors that
  surface from Client::start (token + stdio, empty token, etc).

ClientInner gains effective_connection_token: Option<String> populated
in start(); from_transport now takes the token through (8 args ->
suppressed clippy::too_many_arguments on the internal helper).

Tests:
- protocol_version_test: existing tests updated for the new
  connect-then-ping fallback flow (server responds MethodNotFound on
  connect to exercise the legacy compat path).
- protocol_version_test::connect_handshake_supplies_protocol_version:
  new positive-path test — server responds to connect with a
  protocolVersion.
- lib::tests::build_command_sets_copilot_home_env_when_configured
- lib::tests::build_command_sets_connection_token_env_when_configured
- lib::tests::start_rejects_token_with_stdio_transport
- lib::tests::start_rejects_empty_connection_token

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

tclem and others added 3 commits May 4, 2026 07:45
…rage

Two related changes:

1. Drop the `uuid = "1"` dep added in 02780f0; replace with a
   `generate_connection_token()` helper that pulls 16 bytes from
   `getrandom::getrandom` and hex-encodes them. Same 128 bits of CSPRNG
   entropy, no semantic mismatch (the connection token is an opaque
   secret, not an identifier — typing it as a UUID would conflict with
   the existing pre-1.0 review consensus that schema-shaped IDs stay
   `String`). Output is a 32-char lowercase hex string, distinguishable
   from UUIDs at a glance.

   Rustdoc on the helper documents the decision so a future reader
   doesn't re-litigate it.

2. Address four reviewer items flagged on the github-app sync PR
   (#4399), all of which routed back upstream because src/ and tests/
   are mirrored from copilot-sdk:

   a. `session_config_serializes_instruction_directories_to_camel_case`
      — wire-shape test that `with_instruction_directories(...)`
      populates the field and serializes to `instructionDirectories`.

   b. `resume_session_config_serializes_instruction_directories_to_camel_case`
      — same on the resume path.

   c. `connect_handshake_forwards_explicit_token` and
      `connect_handshake_forwards_auto_generated_token` —
      positive coverage that `tcp_connection_token` actually reaches
      the outbound `connect` request's `token` param. Auto-generated
      case also asserts the shape (32-char lowercase hex) so a
      regression in the helper can't silently weaken loopback
      authentication.

   d. Rewrote the rustdoc on `Client::verify_protocol_version`. It
      claimed "sends a `ping` RPC", but the implementation now tries
      `connect` first and falls back to `ping` only on -32601. New
      docs describe the full handshake sequence and the token-
      forwarding semantics.

Test-support surface: adds two test-only entry points on `Client`
(`from_streams_with_connection_token`, `generate_connection_token_for_test`)
gated behind `cfg(any(test, feature = "test-support"))`, mirroring the
existing `from_streams_with_trace_provider` shape.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codegen was crashing on the post-1.0.41-0 schema with
`TypeError: s.split is not a function` at toPascalCase. Root cause:
the new `connect` JSON-RPC method's `ConnectResult.ok` field is
declared as `{ "type": "boolean", "enum": [true] }` (a single-value
boolean enum used as a "must-be-true" discriminant). The Rust
generator's `emitRustStringEnum` assumes string values, fed a
boolean, and panicked.

Python and Go generators already pre-process the schema with
`stripBooleanLiterals` (utils.ts:146) for exactly this reason —
upstream PR #1176 added the helper precisely because quicktype's
Python/Go renderers crashed on the same input. The TypeScript and
C# generators handle it natively. Rust's generator wasn't pre-
processing, so it inherited the same crash.

Fix: apply `stripBooleanLiterals` to both `apiSchema` and
`sessionEventsSchema` in `rust.ts` before postProcessSchema /
emit. Mirrors the Python/Go invocation pattern. Boolean
literal narrowing isn't expressible in Rust enums anyway —
the field stays `pub ok: bool`.

Regen produces two new types from the post-1.0.41-0 schema:
- `ConnectRequest` (token: Option<String>)
- `ConnectResult` (ok: bool, protocolVersion: u32)
- rpc_methods::CONNECT constant

These reflect the `connect` JSON-RPC method our hand-coded
verify_protocol_version handshake already invokes via
`client.call("connect", ...)`. We don't switch the call site to
the typed RPC because the existing untyped call matches how
`ping` is invoked next door, and the handshake needs the special
MethodNotFound fallback that doesn't fit the typed RPC abstraction.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Now that codegen produces ConnectRequest / ConnectResult types
(b9b4d2b regen output), the hand-coded JSON-building in
Client::connect_handshake is just untyped boilerplate. Switches the
implementation to the typed `client.rpc().connect(ConnectRequest {
token })` call. Same wire shape; same MethodNotFound fallback at the
verify_protocol_version call site (lifted-out fallback, not
swallowed by the handshake helper); typed extraction of
protocol_version replaces the manual `value.get("protocolVersion")`
JSON walk.

ping() stays as a public hand-coded wrapper because the
`Option<&str>` ergonomics don't translate to the typed PingRequest
struct, and removing the public function would be a breaking API
change.

Test fixtures: extended the mock-server `connect` response stubs
in protocol_version_test.rs to include the now-required `version`
field on ConnectResult. Schema declares it required; deserialization
through the typed ConnectResult now enforces it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Cross-SDK Consistency Review ✅

Reviewed the Rust SDK addition against the existing Node.js/TypeScript, Python, Go, and .NET SDK implementations.

Core API Alignment — Consistent ✅

All fundamental APIs from the other SDKs are present in Rust (following Rust naming conventions):

Feature Node.js Python Go .NET Rust
Client lifecycle start/stop/forceStop same Start/Stop/ForceStop StartAsync/StopAsync/ForceStopAsync start/stop/force_stop
Session management createSession/resumeSession same CreateSession/ResumeSession CreateSessionAsync/ResumeSessionAsync create_session/resume_session
Send message send/sendAndWait send/send_and_wait Send/SendAndWait SendAsync/SendAndWaitAsync send/send_and_wait
Session teardown disconnect/destroy disconnect/destroy Disconnect/Destroy DisposeAsync disconnect/destroy
Abort abort abort Abort AbortAsync abort
Model switch setModel set_model SetModel SetModelAsync set_model
Event history getMessages get_messages GetMessages GetMessagesAsync get_messages
Session log log log Log LogAsync log
Client ops ping/getStatus/getAuthStatus/listModels same Ping/GetStatus/GetAuthStatus/ListModels PingAsync/GetStatusAsync/... all present ✅
Session listing listSessions/getSessionMetadata/deleteSession same same (Go) same (Async) all present ✅
Foreground session getForeground/setForegroundSessionId same same (Go) same (Async) all present ✅
Capabilities / UI capabilities/ui capabilities/ui Capabilities/UI Capabilities/Ui both ✅

Intentional Divergences — Well-Documented ✅

The README includes a thorough "Differences From Other SDKs" section. All deviations are intentional and explained:

  • Additional Session convenience methods (get_model, set_mode/get_mode, set_name/get_name, plan/workspace/fleet APIs) — other SDKs expose these only via the generated rpc() namespace
  • Client::send_telemetry / Session::send_telemetry — not yet exposed in other SDKs (not even via rpc())
  • Client::get_quota — convenience wrapper; RPC endpoint is accessible cross-SDK via rpc() namespace
  • Typed newtypes (SessionId, RequestId) — Rust type safety win
  • permission:: module — composable policy builders
  • Transport enum / from_streams — explicit transport selection

Minor Documentation Gap

Session::set_approve_all_permissions is a Rust-only convenience wrapper for session.permissions.setApproveAll (other SDKs use the generated RPC namespace, e.g. Go: session.RPC.Permissions.SetApproveAll()). It's used in tests but isn't listed in the README's "Rust-only API" section alongside the other first-class Session convenience methods. Worth adding a bullet there for completeness.

Similarly, the subscription model divergence (subscribe() returning a channel vs the callback-based on(handler) in Node.js/Python/Go/.NET) could be explicitly noted in the "Shape divergence" section — it's implied by the examples but isn't stated outright.

Scenario Coverage

test/scenarios/RUST_COVERAGE.md documents scenario parity clearly with deferred items well-justified. All major scenarios (transport, sessions, tools, callbacks, prompts) have Rust implementations.


Overall: This PR maintains strong cross-SDK consistency. The Rust SDK is a faithful implementation of the shared protocol with well-documented, idiomatic Rust divergences. No blocking consistency issues found.

Generated by SDK Consistency Review Agent for issue #1164 · ● 3M ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants