Skip to content

fix: unexport internal DlpPattern interface in src/dlp.ts#2437

Merged
lpcox merged 2 commits intomainfrom
copilot/remove-unused-export-dlp-pattern
May 3, 2026
Merged

fix: unexport internal DlpPattern interface in src/dlp.ts#2437
lpcox merged 2 commits intomainfrom
copilot/remove-unused-export-dlp-pattern

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 3, 2026

DlpPattern was exported from src/dlp.ts but never imported anywhere else — it exists solely as the element type of the internal DLP_PATTERNS constant. Exporting internal schema types for a security-sensitive module (DLP) unnecessarily widens the public API surface.

Change

  • src/dlp.ts: Drop export from interface DlpPattern. DLP_PATTERNS remains exported as the intended public API.
// before
export interface DlpPattern { ... }

// after
interface DlpPattern { ... }

Copilot AI changed the title [WIP] Remove unused exported interface DlpPattern from src/dlp.ts fix: unexport internal DlpPattern interface in src/dlp.ts May 3, 2026
Copilot AI requested a review from lpcox May 3, 2026 13:57
Copilot finished work on behalf of lpcox May 3, 2026 13:57
@lpcox lpcox marked this pull request as ready for review May 3, 2026 23:05
@lpcox lpcox requested a review from Mossaka as a code owner May 3, 2026 23:05
Copilot AI review requested due to automatic review settings May 3, 2026 23:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 85.76% 85.84% 📈 +0.08%
Statements 85.64% 85.72% 📈 +0.08%
Functions 88.11% 88.11% ➡️ +0.00%
Branches 78.65% 78.69% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/docker-manager.ts 87.4% → 87.7% (+0.29%) 87.0% → 87.3% (+0.27%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows the public TypeScript API of the DLP module by making DlpPattern internal-only, which matches how the module is currently used: consumers rely on DLP_PATTERNS, not the schema type itself. That keeps an internal type out of the published package surface for a security-sensitive area without changing runtime behavior.

Changes:

  • Remove export from DlpPattern in src/dlp.ts.
  • Keep DLP_PATTERNS exported and typed internally with DlpPattern.
  • Leave the DLP pattern data and module behavior unchanged.
Show a summary per file
File Description
src/dlp.ts Reduces the module's exported type surface by making DlpPattern private while preserving the exported pattern list.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP (list PRs)
GitHub.com connectivity ✅ (HTTP code not expanded — pre-step skipped)
File write/read ❌ (pre-step template vars not expanded; file not found)
BYOK inference (agent → api-proxy → api.githubcopilot.com)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

PR author: @Copilot — Assignees: @lpcox, @Copilot

Overall: PARTIAL (pre-step data missing; BYOK inference confirmed working)

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

🤖 Smoke Test Results

Test Status
GitHub MCP connectivity
GitHub.com HTTP connectivity ⚠️ (pre-step data unavailable)
File write/read ⚠️ (pre-step data unavailable)

PR: fix: unexport internal DlpPattern interface in src/dlp.ts
Author: @Copilot · Assignees: @lpcox, @Copilot

Overall: PARTIAL — MCP ✅, but $\{\{ steps.smoke-data.outputs.* }} template variables were not expanded (pre-step outputs missing).

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Smoke Test Results

✅ GitHub MCP: Listed 2 merged PRs
✅ Playwright: GitHub page verified
✅ File Writing: Test file created
✅ Bash Verification: File contents confirmed

Status: PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Smoke Test

refactor: consolidate env-var forwarding in docker-manager.ts into typed arrays + loops
feat: add 4 agentic code quality workflows
GitHub MCP ❌
safeinputs-gh ❌
Playwright ✅
Tavily ❌
File write/read ✅
Discussion comment ✅
Build AWF ✅
Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ NO
Node.js v24.14.1 v20.20.2 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Result: ❌ Not all versions match — Python and Node.js versions differ between host and chroot environments. Go matches.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #2437 · ● 540.2K ·

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Smoke Test Results

Overall status: PASS

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Smoke Test: Services Connectivity

Check Result
Redis PING ❌ timeout/no response
PostgreSQL pg_isready ❌ no response
PostgreSQL SELECT 1 ❌ skipped (pg unreachable)

Overall: FAILhost.docker.internal is not reachable from this runner. Service containers may not be running or the hostname is not resolvable in this environment.

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox merged commit 26c1d58 into main May 3, 2026
72 of 74 checks passed
@lpcox lpcox deleted the copilot/remove-unused-export-dlp-pattern branch May 3, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Unused exported interface in src/dlp.ts: DlpPattern

3 participants