Enhance publish.yml with permissions and npm changes#111
Open
gracepark wants to merge 2 commits intogithub:mainfrom
Open
Enhance publish.yml with permissions and npm changes#111gracepark wants to merge 2 commits intogithub:mainfrom
gracepark wants to merge 2 commits intogithub:mainfrom
Conversation
Updated publish workflow to include permissions and modify npm publish commands.
There was a problem hiding this comment.
Pull request overview
Updates the release workflow for @github/paste-markdown to support npm trusted publishing/OIDC and to adjust how packages are published from GitHub Actions. This fits into the codebase’s release automation by changing the workflow that publishes the package to npm and GitHub Packages.
Changes:
- Added explicit job permissions, including
id-token: write, to the publish jobs. - Replaced token-based
npm publishcommands withnpm publish --provenance. - Removed the explicit
NODE_AUTH_TOKENenvironment wiring from the publish steps.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Updates npm/GitHub Packages release automation to use explicit permissions and new publish commands. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:50
- Using
--ignore-scriptshere skipsprepublishOnly, so the GitHub Packages publish path will also upload an unbuilt package. In this repo the publishable contents come fromdist/*, but this workflow never generatesdistbefore callingnpm publish.
run: npm --ignore-scripts publish --provenance
- Files reviewed: 1/1 changed files
- Comments generated: 2
| - run: npm whoami; npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.npm_token}} | ||
| - run: npm --ignore-scripts publish --provenance |
Comment on lines
+29
to
+31
| permissions: | ||
| contents: read | ||
| id-token: write |
TylerJDev
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
Updated publish workflow to include permissions and modify npm publish commands as we've migrated to OIDC.