fix: handle stream read errors in responseToReadable#1449
Open
venkat22022202 wants to merge 1 commit intogoogle:mainfrom
Open
fix: handle stream read errors in responseToReadable#1449venkat22022202 wants to merge 1 commit intogoogle:mainfrom
venkat22022202 wants to merge 1 commit intogoogle:mainfrom
Conversation
…dled rejections Fixes google#1443 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1443
The
responseToReadablefunction insrc/goods.tsassigns an async function tors._readwithout error handling. Ifreader.read()throws (e.g. network disconnection, aborted request, corrupted stream), the promise rejection is unhandled and crashes the Node.js process.Fix
Wrapped the async
_readbody in try/catch. Errors are propagated to the stream viars.destroy(err), allowing downstream consumers to handle them gracefully instead of crashing.Usage demo
npm buildbefore committing and verified the bundle updates correctly.run testand confirmed all tests succeed. Added tests to cover my changes if needed.