Prevent keypair from being rotated when saving credentials, only rotate on explicit button click#98
Open
ronak-701685 wants to merge 1 commit intojenkinsci:masterfrom
Conversation
…te on explicit button click
Author
|
Review request: @jglick |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
Member
|
Compare #30. Currently this plugin is not really maintained. If I have some time to actually set aside and think about what is safe and correct I have a list of important changes to make, starting with keypair rotation. From a quick glance this looks reasonable but any change to this plugin requires more than a quick glance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Did
Relevant Issues
Testing done
OpenIDConnectIdToken.mp4
Submitter checklist