test: ignore late worker exceptions in WPT runner#63106
Open
marcopiraccini wants to merge 1 commit intonodejs:mainfrom
Open
test: ignore late worker exceptions in WPT runner#63106marcopiraccini wants to merge 1 commit intonodejs:mainfrom
marcopiraccini wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63106 +/- ##
==========================================
+ Coverage 89.65% 89.67% +0.02%
==========================================
Files 712 712
Lines 220512 220822 +310
Branches 42289 42385 +96
==========================================
+ Hits 197690 198019 +329
+ Misses 14663 14613 -50
- Partials 8159 8190 +31 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WPT semantics: once
done()is called the test result is final. Browsers send any later exception towindow.onerrorand do not fail the test. Node's WPT worker forwarded post-completionuncaughtExceptions to the parent asWorker'error'events, which the runner reports as failures.Affected flaky tests:
wpt/test-timers→html/webappapis/timers/type-long-settimeout.any.jswpt/test-timers→html/webappapis/timers/type-long-setinterval.any.jsFix
Install a no-op
uncaughtExceptionhandler from insideadd_completion_callback, before posting completion. Late exceptions in the worker are then swallowed, matching browser semantics. Scope is one fixture per worker (oneWorkerper spec), so it cannot leak into other tests.