Conversation
p-sawicki
approved these changes
May 5, 2026
ilevkivskyi
approved these changes
May 5, 2026
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Couple optional suggestions for clarifications.
|
|
||
| Mypy now supports experimental parallel and incremental type checking. Use `--num-workers N` | ||
| or `-nN` to use `N` worker processes to type check in parallel. The speedup depends on the | ||
| import structure of your codebase and your environment, but for large projects we've seen |
Member
There was a problem hiding this comment.
Maybe specifically mention that large import cycles will significantly limit the parallelism?
Collaborator
Author
There was a problem hiding this comment.
I though about this, but we do pretty well even with fairly large import cycles. It starts to be a real problem if half the codebase is in a single import cycle, but I don't want to discourage users with large but not excessively so import cycles.
| ``` | ||
|
|
||
| You can still use `--allow-redefinition-old` to fall back to the old behavior. We have no | ||
| plans to remove the legacy behavior. |
Member
There was a problem hiding this comment.
Maybe say that the new beahviour is recommended, while the old one will be maintained on the best effort basis? (Assuming this is what we want.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few sections about major changes, and some minor editing.