Update laravel/passport from v11.10.6 to v12.4.3#1112
Open
outdooracorn wants to merge 2 commits intomainfrom
Open
Update laravel/passport from v11.10.6 to v12.4.3#1112outdooracorn wants to merge 2 commits intomainfrom
outdooracorn wants to merge 2 commits intomainfrom
Conversation
Update composer packages with this command:
```
docker run --rm -it -v $PWD:/app -u $(id -u):$(id -g) composer:2.9.2 \
--ignore-platform-req=ext-pcntl \
--with-all-dependencies \
require \
laravel/passport:^12.4 \
firebase/php-jwt:^7.0 \
absszero/laravel-stackdriver-error-reporting
```
Run `docker compose exec api php artisan vendor:publish --tag=passport-migrations` to add Passport's migrations to the `database/migrations` dir.
Fix `LoginTest::testLoginSuccess()` by using `Artisan::call()` instead of `$this->artisan()` in the `setUp()` method.
Running `passport:install` in tests in this way is a code smell and likely something we want to remove. Not addressed in this PR to avoid scope creep. See these links for more information:
* #604
* https://stackoverflow.com/questions/50113508
* https://laravel.com/docs/12.x/passport#testing
Add `--no-interaction` to `php artisan passport:install` commands in the Makefile and README.
Bug: T424471
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update composer packages with this command:
Run
docker compose exec api php artisan vendor:publish --tag=passport-migrationsto add Passport's migrations to thedatabase/migrationsdir.Fix
LoginTest::testLoginSuccess()by usingArtisan::call()instead of$this->artisan()in thesetUp()method.Add
--no-interactiontophp artisan passport:installcommands in the Makefile and README.Bug: T424471
Co-authored-by: Dat dat.nguyen@wikimedia.de